Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 483613006: Allow null as a synonym for {} when decoding JSON objects. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow null as a synonym for {} when decoding JSON objects. The spec allows this (for interoprability with Lisp-based clients), and we had been doing it correctly for lists and maps, but not for arbitrary objects. R=jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=39382

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/generated_protocol.dart View 87 chunks +261 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart_protocol.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 4 months ago (2014-08-19 21:03:40 UTC) #1
jwren
On 2014/08/19 21:03:40, Paul Berry wrote: LGTM
6 years, 4 months ago (2014-08-19 21:10:21 UTC) #2
Paul Berry
6 years, 4 months ago (2014-08-19 21:13:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 39382 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698