Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 48293002: Remove @deprecated features. (Closed)

Created:
7 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -120 lines) Patch
M pkg/intl/lib/bidi_formatter.dart View 1 chunk +0 lines, -12 lines 1 comment Download
M pkg/logging/lib/logging.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M pkg/logging/test/logging_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/observe/lib/src/change_record.dart View 3 chunks +0 lines, -21 lines 0 comments Download
M pkg/observe/lib/src/observable.dart View 1 chunk +0 lines, -15 lines 0 comments Download
M pkg/observe/lib/src/observable_map.dart View 1 chunk +0 lines, -4 lines 0 comments Download
D pkg/polymer/lib/component_build.dart View 1 chunk +0 lines, -23 lines 0 comments Download
M pkg/unittest/lib/src/iterable_matchers.dart View 2 chunks +1 line, -7 lines 0 comments Download
M sdk/lib/io/file.dart View 2 chunks +0 lines, -30 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-10-28 08:25:57 UTC) #1
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-10-28 13:12:21 UTC) #2
Søren Gjesse
lgtm
7 years, 1 month ago (2013-10-28 13:17:51 UTC) #3
Bob Nystrom
unittest LGTM!
7 years, 1 month ago (2013-10-28 16:22:10 UTC) #4
Alan Knight
Intl part lgtm. https://codereview.chromium.org/48293002/diff/1/pkg/intl/lib/bidi_formatter.dart File pkg/intl/lib/bidi_formatter.dart (right): https://codereview.chromium.org/48293002/diff/1/pkg/intl/lib/bidi_formatter.dart#newcode84 pkg/intl/lib/bidi_formatter.dart:84: /** Um, things in pkg are ...
7 years, 1 month ago (2013-10-28 16:47:18 UTC) #5
Jennifer Messerly
On 2013/10/28 16:47:18, Alan Knight wrote: > Intl part lgtm. > > https://codereview.chromium.org/48293002/diff/1/pkg/intl/lib/bidi_formatter.dart > File ...
7 years, 1 month ago (2013-10-28 17:12:00 UTC) #6
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-10-29 12:00:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r29438 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698