Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 482833002: Add additional flag methods and fields onto the generated Element type. (Closed)

Created:
6 years, 4 months ago by jwren
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Add additional flag methods and fields onto the generated Element type. R=brianwilkerson@google.com, paulberry@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -6 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Element.java View 2 chunks +36 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java_types.dart View 10 chunks +72 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jwren
6 years, 4 months ago (2014-08-18 17:48:41 UTC) #1
scheglov
LGTM
6 years, 4 months ago (2014-08-18 17:51:32 UTC) #2
Paul Berry
lgtm
6 years, 4 months ago (2014-08-18 18:03:44 UTC) #3
Brian Wilkerson
LGTM
6 years, 4 months ago (2014-08-18 18:09:23 UTC) #4
jwren
6 years, 4 months ago (2014-08-18 18:12:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as 39342 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698