Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 48283002: Throw exception when trying to modify HTTP status code when header is already sent (Closed)

Created:
7 years, 1 month ago by Søren Gjesse
Modified:
7 years, 1 month ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Throw exception when trying to modify HTTP status code when header is already sent BUG=http://dartbug.com/14505 R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=29346

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M sdk/lib/io/http_impl.dart View 2 chunks +7 lines, -1 line 0 comments Download
M tests/standalone/io/http_headers_state_test.dart View 1 chunk +13 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years, 1 month ago (2013-10-28 08:23:38 UTC) #1
Anders Johnsen
lgtm
7 years, 1 month ago (2013-10-28 08:55:53 UTC) #2
Søren Gjesse
7 years, 1 month ago (2013-10-28 09:26:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29346 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698