Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 48273006: Any non-special \k is OK. (Closed)

Created:
7 years, 1 month ago by scheglov
Modified:
7 years, 1 month ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Any non-special \k is OK. 12.5 Strings Otherwise, \k indicates the character k for any k not in {n; r; f; b; t; v; x; u}. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=29398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/scanner/Scanner.java View 1 chunk +0 lines, -10 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/scanner/ScannerErrorCode.java View 1 chunk +0 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/scanner/ScannerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-analyzer.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 1 month ago (2013-10-28 21:33:01 UTC) #1
Brian Wilkerson
LGTM
7 years, 1 month ago (2013-10-28 21:35:14 UTC) #2
scheglov
7 years, 1 month ago (2013-10-28 21:40:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29398 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698