Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 48273005: Support Safari 6.1's new stack trace format in pkg/stack_trace. (Closed)

Created:
7 years, 1 month ago by nweiz
Modified:
7 years, 1 month ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support Safari 6.1's new stack trace format in pkg/stack_trace. R=rnystrom@google.com BUG=14534 Committed: https://code.google.com/p/dart/source/detail?r=29399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -12 lines) Patch
M pkg/stack_trace/lib/src/frame.dart View 2 chunks +24 lines, -4 lines 0 comments Download
M pkg/stack_trace/lib/src/trace.dart View 4 chunks +41 lines, -7 lines 0 comments Download
M pkg/stack_trace/test/frame_test.dart View 1 chunk +47 lines, -0 lines 0 comments Download
M pkg/stack_trace/test/trace_test.dart View 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 1 month ago (2013-10-28 20:59:06 UTC) #1
Bob Nystrom
LGTM!
7 years, 1 month ago (2013-10-28 21:40:07 UTC) #2
nweiz
7 years, 1 month ago (2013-10-28 21:50:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29399 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698