When doing SSA type propagation, refine the receiver after a call.

When doing SSA type propagation, refine the receiver after a call.

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29347

[kasperl, 2013-10-28 08:31:42]

LGTM.

https://codereview.chromium.org/48243002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart
(right):

https://codereview.chromium.org/48243002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart:308:
Selector refinedSelector =
Consider calling this 'selector' and use it instead instead of
instruction.selector below.

https://codereview.chromium.org/48243002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart:314: &&
!instruction.selector.isClosureCall()) {
instruction.selector -> refinedSelector

https://codereview.chromium.org/48243002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart:315:
TypeMask oldType = receiverType.computeMask(compiler);
Rename to oldMask and newMask.

https://codereview.chromium.org/48243002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart:321: HType
newHType = new HType.fromMask(newType, compiler);
I'd rename this to newType -- it's used a lot and having the H in the name makes
it harder to read.

[ngeoffray, 2013-10-28 08:53:53]

Thanks Kasper.

https://codereview.chromium.org/48243002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart
(right):

https://codereview.chromium.org/48243002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart:308:
Selector refinedSelector =
On 2013/10/28 08:31:42, kasperl wrote:
> Consider calling this 'selector' and use it instead instead of
> instruction.selector below.

Done.

https://codereview.chromium.org/48243002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart:314: &&
!instruction.selector.isClosureCall()) {
On 2013/10/28 08:31:42, kasperl wrote:
> instruction.selector -> refinedSelector

Done.

https://codereview.chromium.org/48243002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart:315:
TypeMask oldType = receiverType.computeMask(compiler);
On 2013/10/28 08:31:42, kasperl wrote:
> Rename to oldMask and newMask.

Done.

https://codereview.chromium.org/48243002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart:321: HType
newHType = new HType.fromMask(newType, compiler);
On 2013/10/28 08:31:42, kasperl wrote:
> I'd rename this to newType -- it's used a lot and having the H in the name
makes
> it harder to read.

Done.

[ngeoffray, 2013-10-28 09:41:10]

Committed patchset #5 manually as r29347 (presubmit successful).