Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 48133002: Remove deprecated dart:utf library. (Closed)

Created:
7 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, kustermann
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Merged to head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1694 lines) Patch
M runtime/vm/benchmark_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/bootstrap.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/object.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/object_store.h View 1 4 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/object_store.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/symbols.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/vm.gypi View 1 4 chunks +0 lines, -36 lines 0 comments Download
M sdk/lib/_internal/libraries.dart View 1 1 chunk +0 lines, -4 lines 0 comments Download
D sdk/lib/utf/utf.dart View 1 chunk +0 lines, -289 lines 0 comments Download
D sdk/lib/utf/utf16.dart View 1 chunk +0 lines, -329 lines 0 comments Download
D sdk/lib/utf/utf32.dart View 1 chunk +0 lines, -335 lines 0 comments Download
D sdk/lib/utf/utf8.dart View 1 chunk +0 lines, -345 lines 0 comments Download
D sdk/lib/utf/utf_sources.gypi View 1 chunk +0 lines, -15 lines 0 comments Download
D sdk/lib/utf/utf_stream.dart View 1 chunk +0 lines, -240 lines 0 comments Download
D tests/lib/utf/utf8_test.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D tests/lib/utf/utf_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
M tools/testing/dart/record_and_replay.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/testing/dart/utils.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M utils/tests/string_encoding/unicode_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M utils/tests/string_encoding/utf8_benchmarks.dart View 2 chunks +7 lines, -12 lines 0 comments Download
M utils/tests/string_encoding/utf8_test.dart View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Lasse Reichstein Nielsen
Schneider, please check the VM changes. Martin, I will probably need a chromium bindings change ...
7 years, 1 month ago (2013-10-28 07:14:55 UTC) #1
Florian Schneider
runtime/vm lgtm.
7 years, 1 month ago (2013-10-28 11:57:50 UTC) #2
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-10-30 11:28:00 UTC) #3
Søren Gjesse
lgtm, thanks
7 years, 1 month ago (2013-10-30 12:14:01 UTC) #4
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-10-30 12:26:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r29537 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698