Issue 481023002: Fix polymorphic inlining of non-native recognized methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 481023002: Fix polymorphic inlining of non-native recognized methods. (Closed)

Created:
6 years, 4 months ago by Florian Schneider

Modified:
6 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix polymorphic inlining of non-native recognized methods. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39335

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
	M	runtime/vm/flow_graph_inliner.cc	View		1 chunk	+3 lines, -6 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/481023002/diff/1/runtime/vm/flow_graph_inliner.cc File runtime/vm/flow_graph_inliner.cc (right): https://codereview.chromium.org/481023002/diff/1/runtime/vm/flow_graph_inliner.cc#newcode1288 runtime/vm/flow_graph_inliner.cc:1288: const Function& target) { add one space here ...

6 years, 4 months ago (2014-08-18 15:37:34 UTC) #2

Florian Schneider

6 years, 4 months ago (2014-08-18 15:58:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r39335 (presubmit successful).

Expand Messages | Collapse Messages