Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 480413003: more invocation code completion improvements (Closed)

Created:
6 years, 4 months ago by danrubel
Modified:
6 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

more invocation code completion improvements and pull common suggestion builders into new library BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39370

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -141 lines) Patch
M pkg/analysis_server/lib/src/services/completion/imported_type_computer.dart View 5 chunks +14 lines, -64 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/invocation_computer.dart View 2 chunks +29 lines, -73 lines 0 comments Download
A pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart View 1 chunk +150 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/invocation_computer_test.dart View 1 chunk +52 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danrubel
6 years, 4 months ago (2014-08-19 03:55:14 UTC) #1
scheglov
LGTM
6 years, 4 months ago (2014-08-19 05:39:58 UTC) #2
danrubel
6 years, 4 months ago (2014-08-19 14:09:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 39370 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698