Issue 480063002: Update pacakge generation from configuration file

Issue 480063002: Update pacakge generation from configuration file (Closed)

Created:
6 years, 4 months ago by Søren Gjesse

Modified:
6 years, 4 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/googleapis.git@master

Visibility:
Public.

More Reviews

Description

Update pacakge generation from configuration file * Add version, author and homepage to config.yaml * Generate description R=kustermann@google.com BUG= Committed: https://github.com/dart-lang/gcloud/commit/d880fd7

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : Minor fix #

Total comments: 2

Patch Set 4 : Updated #

Total comments: 2

Patch Set 5 : Addressed review comments #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+288 lines, -154 lines)			Patch
M	config.yaml	View	1 2 3	1 chunk	+108 lines, -131 lines	0 comments	Download
M	main.dart	View	1 2 3 4	2 chunks	+124 lines, -23 lines	0 comments	Download
A +	resources/LICENSE	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
A	resources/README.md	View	1 2 3	1 chunk	+55 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kustermann

lgtm - but wait before the other one has landed https://codereview.chromium.org/480063002/diff/40001/main.dart File main.dart (right): https://codereview.chromium.org/480063002/diff/40001/main.dart#newcode42 ...

6 years, 4 months ago (2014-08-18 14:04:05 UTC) #2

Søren Gjesse

PTAL Updated to handle README.md and LICENSE generation. Updated config.yaml. https://codereview.chromium.org/480063002/diff/40001/main.dart File main.dart (right): https://codereview.chromium.org/480063002/diff/40001/main.dart#newcode42 ...

6 years, 4 months ago (2014-08-19 13:53:13 UTC) #3

kustermann

lgtm -- but the main function gets ugly :( https://codereview.chromium.org/480063002/diff/60001/main.dart File main.dart (right): https://codereview.chromium.org/480063002/diff/60001/main.dart#newcode28 main.dart:28: ...

6 years, 4 months ago (2014-08-19 14:20:46 UTC) #4

Søren Gjesse

https://codereview.chromium.org/480063002/diff/60001/main.dart File main.dart (right): https://codereview.chromium.org/480063002/diff/60001/main.dart#newcode28 main.dart:28: pacakge. On 2014/08/19 14:20:46, kustermann wrote: > -> package. ...

6 years, 4 months ago (2014-08-20 09:12:53 UTC) #5

Søren Gjesse

6 years, 4 months ago (2014-08-20 09:13:08 UTC) #6

Message was sent while issue was closed.

Committed patchset #5 manually as d880fd7 (presubmit successful).

Expand Messages | Collapse Messages