Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 47933006: Build fixes: adds arguments to the pub-build plugin to configure whether 'js' (Closed)

Created:
7 years, 1 month ago by Siggi Cherem (dart-lang)
Modified:
7 years, 1 month ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Build fixes: adds arguments to the pub-build plugin to configure whether 'js' and 'csp' options. Ensure we can call main in the generated code (no need to export init.dart anymore). R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=29409

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -43 lines) Patch
M pkg/polymer/lib/src/build/script_compactor.dart View 2 chunks +10 lines, -2 lines 0 comments Download
M pkg/polymer/lib/transformer.dart View 1 chunk +21 lines, -18 lines 1 comment Download
M pkg/polymer/test/build/all_phases_test.dart View 7 chunks +28 lines, -17 lines 0 comments Download
M pkg/polymer/test/build/script_compactor_test.dart View 4 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
7 years, 1 month ago (2013-10-29 00:26:41 UTC) #1
Jennifer Messerly
lgtm https://codereview.chromium.org/47933006/diff/1/pkg/polymer/lib/transformer.dart File pkg/polymer/lib/transformer.dart (right): https://codereview.chromium.org/47933006/diff/1/pkg/polymer/lib/transformer.dart#newcode40 pkg/polymer/lib/transformer.dart:40: directlyIncludeJS: args['js'] != false, // default to true ...
7 years, 1 month ago (2013-10-29 02:15:35 UTC) #2
Siggi Cherem (dart-lang)
On 2013/10/29 02:15:35, John Messerly wrote: > lgtm > > https://codereview.chromium.org/47933006/diff/1/pkg/polymer/lib/transformer.dart > File pkg/polymer/lib/transformer.dart (right): ...
7 years, 1 month ago (2013-10-29 02:20:12 UTC) #3
Siggi Cherem (dart-lang)
7 years, 1 month ago (2013-10-29 02:51:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r29409 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698