Issue 47933004: VM: Fix bug in polymorphic inlining of recognized methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 47933004: VM: Fix bug in polymorphic inlining of recognized methods. (Closed)

Created:
7 years, 1 month ago by fschneider

Modified:
7 years, 1 month ago

Reviewers:
Florian Schneider, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

VM: Fix bug in polymorphic inlining of recognized methods. The inliner has to insert a redefinition of the receiver to prevent illegal hoisting of instructions that depend on the receiver class id. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=29389

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -20 lines)			Patch
M	runtime/vm/flow_graph_inliner.cc	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View		4 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View		12 chunks	+27 lines, -20 lines	0 comments	Download
A	tests/language/vm/optimized_polymorphic_list_access_test.dart	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

fschneider

7 years, 1 month ago (2013-10-28 20:20:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r29389 (presubmit successful).

Expand Messages | Collapse Messages