Issue 47923022: Use BytesBuilder in pkg:http, when accumulating binary data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 47923022: Use BytesBuilder in pkg:http, when accumulating binary data. (Closed)

Created:
7 years, 1 month ago by Anders Johnsen

Modified:
7 years, 1 month ago

Reviewers:
nweiz, Søren Gjesse

CC:
reviews_dartlang.org, Bob Nystrom, nweiz

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use BytesBuilder in pkg:http, when accumulating binary data. This should speed up the library significant. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29739

Patch Set 1 #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	pkg/http/lib/src/byte_stream.dart	View		1 chunk	+2 lines, -5 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Committed patchset #1 manually as r29739 (presubmit successful).

7 years, 1 month ago (2013-11-01 10:19:07 UTC) #4

nweiz

One style change, otherwise lgtm. https://codereview.chromium.org/47923022/diff/1/pkg/http/lib/src/byte_stream.dart File pkg/http/lib/src/byte_stream.dart (right): https://codereview.chromium.org/47923022/diff/1/pkg/http/lib/src/byte_stream.dart#newcode27 pkg/http/lib/src/byte_stream.dart:27: .then((builder) => builder.takeBytes()); Indent ...

7 years, 1 month ago (2013-11-01 18:31:18 UTC) #5

Anders Johnsen

7 years, 1 month ago (2013-11-04 07:13:34 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/47923022/diff/1/pkg/http/lib/src/byte_stream....
File pkg/http/lib/src/byte_stream.dart (right):

https://codereview.chromium.org/47923022/diff/1/pkg/http/lib/src/byte_stream....
pkg/http/lib/src/byte_stream.dart:27: .then((builder) => builder.takeBytes());
On 2013/11/01 18:31:19, nweiz wrote:
> Indent this two more spaces.

Done: https://codereview.chromium.org/57653002

Expand Messages | Collapse Messages