Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 478933003: Merge two constants.dart into one. (Closed)

Created:
6 years, 4 months ago by scheglov
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -143 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_highlights.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_hover.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_navigation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_occurrences.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_outline.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_overrides.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/element.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/error.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/constants.dart View 1 chunk +91 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_completion.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_server.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/edit/fix.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/search/search_domain.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/search/search_result.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/search/type_hierarchy.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/completion_suggestion.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/analysis_server/lib/src/services/constants.dart View 1 chunk +0 lines, -96 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/change.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/get_errors_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_errors_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_hover_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_highlights_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_navigation_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_occurrences_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_outline_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_overrides_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/computer/element_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/computer/error_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/domain_server_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/edit/assists_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/edit/edit_domain_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/search/abstract_search_domain.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/search/element_references_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/search/member_declarations_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/search/member_references_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/search/search_domain_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/search/search_result_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/top_level_declarations_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/search/type_hierarchy_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/change_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 4 months ago (2014-08-18 21:32:20 UTC) #1
Paul Berry
lgtm
6 years, 4 months ago (2014-08-18 21:34:15 UTC) #2
scheglov
Committed patchset #1 manually as 39355 (presubmit successful).
6 years, 4 months ago (2014-08-18 21:35:21 UTC) #3
Brian Wilkerson
6 years, 4 months ago (2014-08-18 21:46:59 UTC) #4
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698