Issue 478653002: Fix bugs from my last CL in intrinsics code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 478653002: Fix bugs from my last CL in intrinsics code. (Closed)

Created:
6 years, 4 months ago by Florian Schneider

Modified:
6 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bugs from my last CL in intrinsics code. x64 and ARM64: No PP register is set up in intrinsics code (use kNoPP instead) x64: Can't use near jump for slow-path jump because of code size. Removed duplicate call to update allocation stats on all platforms. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39289

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -7 lines)			Patch
M	runtime/vm/intrinsifier_arm.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/intrinsifier_arm64.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/intrinsifier_mips.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

6 years, 4 months ago (2014-08-15 14:06:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r39289 (presubmit successful).

Expand Messages | Collapse Messages