Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 477613002: Try running ie10 in a new window instead of an iframe. (Closed)

Created:
6 years, 4 months ago by ricow1
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Try running ie10 in a new window instead of an iframe. We are seeing issues where it seems that we are getting unittest-suite-success messages out of the blue and this may be related to: https://code.google.com/p/dart/issues/detail?id=17825 This could be the old javascript still running in the iframe posting the event. R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=39245

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/testing/dart/browser_controller.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
6 years, 4 months ago (2014-08-14 12:12:12 UTC) #1
ricow1
+efortuna
6 years, 4 months ago (2014-08-14 12:12:43 UTC) #2
Bill Hesse
lgtm
6 years, 4 months ago (2014-08-14 12:36:17 UTC) #3
ricow1
Committed patchset #1 manually as r39245 (presubmit successful).
6 years, 4 months ago (2014-08-14 12:36:57 UTC) #4
Emily Fortuna
6 years, 4 months ago (2014-08-14 17:18:28 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698