Issue 47753002: Issue 14306. It is compile-time error to reference non-constructor in const redirecting constructor.

Issue 47753002: Issue 14306. It is compile-time error to reference non-constructor in const redirecting constructor. (Closed)

Created:
7 years, 1 month ago by scheglov

Modified:
7 years, 1 month ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 14306. It is compile-time error to reference non-constructor in const redirecting constructor. https://code.google.com/p/dart/issues/detail?id=14306 R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=29337

Patch Set 2 : Fix for review comment #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -34 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java	View	1	6 chunks	+43 lines, -23 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View		1 chunk	+45 lines, -0 lines	0 comments	Download
M	tests/language/language_analyzer.status	View		1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/47753002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java (right): https://codereview.chromium.org/47753002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java#newcode915 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java:915: private RedirectingConstructorKind isTypeNameTargetInRedirectedConstructor(TypeName typeName) { nit: "is" methods ...

7 years, 1 month ago (2013-10-27 20:25:22 UTC) #2

jwren

On 2013/10/27 20:25:22, Brian Wilkerson wrote: > LGTM > > https://codereview.chromium.org/47753002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java > File > editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java ...

7 years, 1 month ago (2013-10-27 21:08:00 UTC) #3

scheglov

Committed patchset #2 manually as r29337 (presubmit successful).

7 years, 1 month ago (2013-10-28 00:00:52 UTC) #4

scheglov

7 years, 1 month ago (2013-10-28 00:01:21 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/47753002/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java
(right):

https://codereview.chromium.org/47753002/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java:915:
private RedirectingConstructorKind
isTypeNameTargetInRedirectedConstructor(TypeName typeName) {
On 2013/10/27 20:25:23, Brian Wilkerson wrote:
> nit: "is" methods should return boolean values. Consider renaming this method
to
> "getRedirectingConstructorKind".

Done.

Expand Messages | Collapse Messages