Issue 47743005: test.py: Run the analyzer on all dart files in the sdk.

Issue 47743005: test.py: Run the analyzer on all dart files in the sdk. (Closed)

Created:
7 years, 1 month ago by kustermann

Modified:
7 years, 1 month ago

Reviewers:
ricow1, bakster

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

test.py: Run the analyzer on all dart files in the sdk. BUG=http://dartbug.com/13024 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=29362

Patch Set 1 #

Total comments: 4

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+179 lines, -46 lines)			Patch
M	dart/tests/lib/analyzer/analyze_library.status	View	1 chunk	+108 lines, -0 lines	0 comments	Download
D	dart/tests/lib/analyzer/test_config.dart	View	1 chunk	+0 lines, -31 lines	0 comments	Download
M	dart/tools/test.dart	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	dart/tools/testing/dart/test_runner.dart	View	5 chunks	+30 lines, -9 lines	0 comments	Download
M	dart/tools/testing/dart/test_suite.dart	View	2 chunks	+41 lines, -3 lines	4 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

As requested, this CL implements support for analyzing all dart files in the sdk (http://dartbug.com/13024). ...

7 years, 1 month ago (2013-10-28 14:21:11 UTC) #1

ricow1

LGTM https://codereview.chromium.org/47743005/diff/1/dart/tools/testing/dart/test_suite.dart File dart/tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/47743005/diff/1/dart/tools/testing/dart/test_suite.dart#newcode1608 dart/tools/testing/dart/test_suite.dart:1608: [ 'lib' ], here you have spaces around ...

7 years, 1 month ago (2013-10-28 14:37:33 UTC) #2

kustermann

Committed patchset #1 manually as r29362 (presubmit successful).

7 years, 1 month ago (2013-10-28 14:46:08 UTC) #3

kustermann

7 years, 1 month ago (2013-10-28 14:47:20 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/47743005/diff/1/dart/tools/testing/dart/test_...
File dart/tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/47743005/diff/1/dart/tools/testing/dart/test_...
dart/tools/testing/dart/test_suite.dart:1608: [ 'lib' ],
On 2013/10/28 14:37:34, ricow1 wrote:
> here you have spaces around the value, right below you don't

Done.

https://codereview.chromium.org/47743005/diff/1/dart/tools/testing/dart/test_...
dart/tools/testing/dart/test_suite.dart:1613:
options.add('--show-sdk-warnings');
On 2013/10/28 14:37:34, ricow1 wrote:
> add a comment that this is deprecated

Done.

Expand Messages | Collapse Messages