Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 477383002: Checks for shadowing in 'Rename Class Member' refactoring. (Closed)

Created:
6 years, 4 months ago by scheglov
Modified:
6 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Checks for shadowing in 'Rename Class Member' refactoring. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=39319

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -36 lines) Patch
M pkg/analysis_services/lib/src/refactoring/rename_class_member.dart View 4 chunks +79 lines, -12 lines 0 comments Download
M pkg/analysis_services/test/refactoring/rename_class_member_test.dart View 4 chunks +243 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 4 months ago (2014-08-16 18:20:05 UTC) #1
Brian Wilkerson
LGTM
6 years, 4 months ago (2014-08-17 14:33:36 UTC) #2
scheglov
6 years, 4 months ago (2014-08-17 20:22:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 39319 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698