Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 47703006: Implement SharedOptions in test scripts. (Closed)

Created:
7 years, 1 month ago by ngeoffray
Modified:
7 years, 1 month ago
Reviewers:
ricow1, kustermann
CC:
reviews_dartlang.org, Søren Gjesse
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M tools/testing/dart/test_suite.dart View 1 9 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ngeoffray
Here's a self contained CL for the change in the test scripts.
7 years, 1 month ago (2013-10-30 13:42:54 UTC) #1
ricow1
What about dartium? https://codereview.chromium.org/47703006/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/47703006/diff/1/tools/testing/dart/test_suite.dart#newcode819 tools/testing/dart/test_suite.dart:819: } as discussed offline we may ...
7 years, 1 month ago (2013-10-30 13:54:26 UTC) #2
ngeoffray
Thanks Rico and Martin. PTAL.
7 years, 1 month ago (2013-10-30 14:42:43 UTC) #3
kustermann
LGTM
7 years, 1 month ago (2013-10-30 14:59:53 UTC) #4
ricow1
LGTM
7 years, 1 month ago (2013-10-30 16:58:01 UTC) #5
ngeoffray
7 years, 1 month ago (2013-10-30 17:30:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r29568 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698