Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 476163002: Add an integration test for analysis.overrides. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add an integration test for analysis.overrides. Also remove the note from the API documentation saying that analysis.overrides only works for overrides of a superclass. Interface overrides work too. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39302

Patch Set 1 #

Patch Set 2 : Fix long lines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -12 lines) Patch
M pkg/analysis_server/doc/api.html View 1 chunk +1 line, -4 lines 0 comments Download
A pkg/analysis_server/test/integration/analysis/overrides_test.dart View 1 1 chunk +120 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 4 months ago (2014-08-15 14:34:38 UTC) #1
scheglov
LGTM
6 years, 4 months ago (2014-08-15 14:36:52 UTC) #2
Paul Berry
6 years, 4 months ago (2014-08-15 16:56:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r39302 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698