Issue 475763002: VM: Small cleanup in optimizer and intrinsics code.

Issue 475763002: VM: Small cleanup in optimizer and intrinsics code. (Closed)

Created:
6 years, 4 months ago by Florian Schneider

Modified:
6 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

VM: Small cleanup in optimizer and intrinsics code. 1. Use macro-assembler instructions for allocation in intrinsics. 2. Refactor two helpers in the optimizer that are almost identical. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39287

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -191 lines)			Patch
M	runtime/vm/flow_graph_optimizer.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1	6 chunks	+13 lines, -28 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View		1 chunk	+3 lines, -33 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm64.cc	View		1 chunk	+3 lines, -33 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View		1 chunk	+3 lines, -30 lines	0 comments	Download
M	runtime/vm/intrinsifier_mips.cc	View		1 chunk	+3 lines, -32 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View		1 chunk	+3 lines, -33 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/475763002/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/475763002/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode2270 runtime/vm/flow_graph_optimizer.cc:2270: InstanceCallInstr* call, bool is_method_extractor) const { I would ...

6 years, 4 months ago (2014-08-14 14:21:13 UTC) #2

Florian Schneider

https://codereview.chromium.org/475763002/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/475763002/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode2270 runtime/vm/flow_graph_optimizer.cc:2270: InstanceCallInstr* call, bool is_method_extractor) const { On 2014/08/14 14:21:13, ...

6 years, 4 months ago (2014-08-15 12:08:37 UTC) #3

Florian Schneider

6 years, 4 months ago (2014-08-15 12:53:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r39287 (presubmit successful).

Expand Messages | Collapse Messages