Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 47573002: Reland https://code.google.com/p/dart/source/detail?r=29315: (Closed)

Created:
7 years, 1 month ago by Ivan Posva
Modified:
7 years, 1 month ago
Reviewers:
Cutch, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, floitsch
Visibility:
Public.

Description

Reland https://code.google.com/p/dart/source/detail?r=29315: - Make sure to keep the main/control port opened until the isolate is finished. - Account for the number of opened control ports to be able to determine whether there are live ports. - Ensure that the spawned isolated is kept alive until the initial startup message can be handled. - Add more isolate tracing output. - Use the control port for the debugger id. Committed: https://code.google.com/p/dart/source/detail?r=29323

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -19 lines) Patch
M runtime/lib/isolate.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/lib/isolate_patch.dart View 4 chunks +23 lines, -9 lines 2 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/debugger.cc View 2 chunks +2 lines, -4 lines 1 comment Download
M runtime/vm/isolate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/port.cc View 2 chunks +13 lines, -0 lines 2 comments Download

Messages

Total messages: 2 (0 generated)
Ivan Posva
TBR (relanding previously reviewed code). -Ivan https://codereview.chromium.org/47573002/diff/1/runtime/lib/isolate_patch.dart File runtime/lib/isolate_patch.dart (right): https://codereview.chromium.org/47573002/diff/1/runtime/lib/isolate_patch.dart#newcode167 runtime/lib/isolate_patch.dart:167: var keepAlivePort = ...
7 years, 1 month ago (2013-10-27 14:33:16 UTC) #1
Ivan Posva
7 years, 1 month ago (2013-10-27 14:34:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r29323 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698