Issue 475563002: Inline Int32x4 constructor

Issue 475563002: Inline Int32x4 constructor (Closed)

Created:
6 years, 4 months ago by Cutch

Modified:
6 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Google), zra, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Inline Int32x4 constructor (avoids a runtime call for every websocket message in dart:io) R=srdjan@google.com, zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=39255

Patch Set 3 : #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+263 lines, -9 lines)			Patch
M	runtime/platform/globals.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1	4 chunks	+22 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2	5 chunks	+55 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 2	1 chunk	+36 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View		2 chunks	+49 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2	1 chunk	+31 lines, -0 lines	1 comment	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2	2 chunks	+51 lines, -3 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

zra

The test passes pretty consistently on ARM hardware. I wonder if something is going wrong ...

6 years, 4 months ago (2014-08-13 22:05:31 UTC) #2

Cutch

https://codereview.chromium.org/475563002/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/475563002/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode8116 runtime/vm/flow_graph_optimizer.cc:8116: On 2014/08/13 22:05:31, zra wrote: > Extra newline. Done. ...

6 years, 4 months ago (2014-08-14 14:41:04 UTC) #3

Cutch

On 2014/08/13 22:05:31, zra wrote: > The test passes pretty consistently on ARM hardware. I ...

6 years, 4 months ago (2014-08-14 14:42:31 UTC) #4

zra

I've patched this in on Linux and Mac as well and haven't been able to ...

6 years, 4 months ago (2014-08-14 16:24:07 UTC) #5

srdjan

lgtm https://codereview.chromium.org/475563002/diff/20001/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/475563002/diff/20001/runtime/vm/intermediate_language.h#newcode6420 runtime/vm/intermediate_language.h:6420: ASSERT(idx >= 0 && idx < 4); Add ...

6 years, 4 months ago (2014-08-14 16:33:03 UTC) #6

Cutch

https://codereview.chromium.org/475563002/diff/20001/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/475563002/diff/20001/runtime/vm/intermediate_language.h#newcode6420 runtime/vm/intermediate_language.h:6420: ASSERT(idx >= 0 && idx < 4); On 2014/08/14 ...

6 years, 4 months ago (2014-08-14 17:21:35 UTC) #7

Cutch

Committed patchset #3 manually as 39255 (presubmit successful).

6 years, 4 months ago (2014-08-14 17:27:59 UTC) #9

Vyacheslav Egorov (Google)

6 years, 4 months ago (2014-08-15 11:02:05 UTC) #10

Message was sent while issue was closed.

DBC

https://codereview.chromium.org/475563002/diff/40001/runtime/vm/intermediate_...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/475563002/diff/40001/runtime/vm/intermediate_...
runtime/vm/intermediate_language_ia32.cc:4180: __ movl(Address(ESP, 0 *
kInt32Size), v0);
For register use on ia32 it might have been better to have these arguments
already pushed to the stack with PushArgument. Otherwise I foresee excessive
spilling around these constructors.

Expand Messages | Collapse Messages