Issue 475543002: New analyzer snapshot, add format/formatList.

Issue 475543002: New analyzer snapshot, add format/formatList. (Closed)

Created:
6 years, 4 months ago by scheglov

Modified:
6 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

New analyzer snapshot, add format/formatList. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=39222

Patch Set 1 #

Total comments: 2

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+637 lines, -1389 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart	View	2 chunks	+28 lines, -15 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java	View	6 chunks	+52 lines, -4 lines	0 comments	Download
M	pkg/analysis_services/lib/correction/assist.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_services/lib/correction/fix.dart	View	1 chunk	+15 lines, -15 lines	0 comments	Download
M	pkg/analysis_services/lib/src/correction/assist.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_services/lib/src/correction/fix.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_services/lib/src/correction/strings.dart	View	1 chunk	+0 lines, -28 lines	0 comments	Download
M	pkg/analysis_services/lib/src/generated/proposal.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_services/lib/src/refactoring/rename_constructor.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_services/test/correction/strings_test.dart	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/engine.dart	View	16 chunks	+14 lines, -500 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/error.dart	View	178 chunks	+332 lines, -332 lines	2 comments	Download
M	pkg/analyzer/lib/src/generated/java_core.dart	View	2 chunks	+28 lines, -15 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/parser.dart	View	1 chunk	+145 lines, -145 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/scanner.dart	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	pkg/analyzer/test/generated/all_the_rest.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/generated/engine_test.dart	View	25 chunks	+8 lines, -311 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/475543002/diff/1/pkg/analyzer/lib/src/generated/error.dart File pkg/analyzer/lib/src/generated/error.dart (right): https://codereview.chromium.org/475543002/diff/1/pkg/analyzer/lib/src/generated/error.dart#newcode290 pkg/analyzer/lib/src/generated/error.dart:290: static const AngularCode CANNOT_PARSE_SELECTOR = const AngularCode("CANNOT_PARSE_SELECTOR", 0, ...

6 years, 4 months ago (2014-08-13 20:45:04 UTC) #2

scheglov

https://codereview.chromium.org/475543002/diff/1/pkg/analyzer/lib/src/generated/error.dart File pkg/analyzer/lib/src/generated/error.dart (right): https://codereview.chromium.org/475543002/diff/1/pkg/analyzer/lib/src/generated/error.dart#newcode290 pkg/analyzer/lib/src/generated/error.dart:290: static const AngularCode CANNOT_PARSE_SELECTOR = const AngularCode("CANNOT_PARSE_SELECTOR", 0, "The ...

6 years, 4 months ago (2014-08-13 21:51:44 UTC) #3

scheglov

6 years, 4 months ago (2014-08-13 21:51:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as 39222 (presubmit successful).

Expand Messages | Collapse Messages