Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 475413002: Initial generator for google API packages (Closed)

Created:
6 years, 4 months ago by Søren Gjesse
Modified:
6 years, 4 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/googleapis.git@master
Visibility:
Public.

Description

Initial generator for google API packages Holds a configuration file with: * which API goes into which package * which API to ignore Then just calls the discovery generator to do the job. The configuration needs to be updated with more information (version, description, etc.) which goes into the pubspec.yaml R=kustermann@google.com BUG= Committed: https://github.com/dart-lang/gcloud/commit/bf303e7

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -0 lines) Patch
A config.yaml View 1 chunk +137 lines, -0 lines 0 comments Download
A main.dart View 1 chunk +58 lines, -0 lines 4 comments Download
A pubspec.lock View 1 chunk +75 lines, -0 lines 0 comments Download
A pubspec.yaml View 1 chunk +9 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
This depends on https://codereview.chromium.org/478663002/
6 years, 4 months ago (2014-08-15 14:08:54 UTC) #1
kustermann
lgtm -- but we don't do fine-grained dependency management before the experimental branch is merged ...
6 years, 4 months ago (2014-08-18 09:32:03 UTC) #2
Søren Gjesse
https://codereview.chromium.org/475413002/diff/1/main.dart File main.dart (right): https://codereview.chromium.org/475413002/diff/1/main.dart#newcode10 main.dart:10: var config = loadYaml(new File('config.yaml').readAsStringSync()); On 2014/08/18 09:32:03, kustermann ...
6 years, 4 months ago (2014-08-18 11:10:45 UTC) #3
Søren Gjesse
6 years, 4 months ago (2014-08-18 11:12:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as bf303e7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698