Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 475143003: Fix code generated matchers to handle recursive objects. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix code generated matchers to handle recursive objects. This requires using a wrapper that creating the matchers lazily (when they're first used), so that a matcher can refer to itself without causing a circularity during initialization. R=jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=39274

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -176 lines) Patch
M pkg/analysis_server/test/integration/integration_tests.dart View 1 chunk +53 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 95 chunks +174 lines, -174 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_matchers.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 4 months ago (2014-08-14 22:13:53 UTC) #1
jwren
LGTM
6 years, 4 months ago (2014-08-14 22:37:56 UTC) #2
Paul Berry
6 years, 4 months ago (2014-08-14 22:45:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r39274 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698