Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 47513008: Expose 'serveFile' on VirtualDirectory. (Closed)

Created:
7 years, 1 month ago by Anders Johnsen
Modified:
7 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Expose 'serveFile' on VirtualDirectory. This makes it possible to easy forward directory requets to e.g. 'index.html'. BUG=http://code.google.com/p/dart/issues/detail?id=14333 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29430

Patch Set 1 #

Total comments: 4

Patch Set 2 : Expand documentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M pkg/http_server/lib/src/virtual_directory.dart View 1 3 chunks +16 lines, -2 lines 0 comments Download
M pkg/http_server/test/virtual_directory_test.dart View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
7 years, 1 month ago (2013-10-28 16:12:09 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/47513008/diff/1/pkg/http_server/lib/src/virtual_directory.dart File pkg/http_server/lib/src/virtual_directory.dart (right): https://codereview.chromium.org/47513008/diff/1/pkg/http_server/lib/src/virtual_directory.dart#newcode149 pkg/http_server/lib/src/virtual_directory.dart:149: * Please mention that this will handle the ...
7 years, 1 month ago (2013-10-29 07:50:01 UTC) #2
Anders Johnsen
https://codereview.chromium.org/47513008/diff/1/pkg/http_server/lib/src/virtual_directory.dart File pkg/http_server/lib/src/virtual_directory.dart (right): https://codereview.chromium.org/47513008/diff/1/pkg/http_server/lib/src/virtual_directory.dart#newcode149 pkg/http_server/lib/src/virtual_directory.dart:149: * On 2013/10/29 07:50:01, Søren Gjesse wrote: > Please ...
7 years, 1 month ago (2013-10-29 10:17:22 UTC) #3
Anders Johnsen
7 years, 1 month ago (2013-10-29 10:17:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r29430 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698