Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 473913005: Fix vm/cc/StaticNonNullSumCallCodegen. (Closed)

Created:
6 years, 4 months ago by Vyacheslav Egorov (Google)
Modified:
6 years, 4 months ago
Reviewers:
siva, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix vm/cc/StaticNonNullSumCallCodegen. Instead of passing null wrapped in the Smi handle use Instance handle. We have the following behavior: Smi::ZoneHandle().IsSmi() -> true Smi::Cast(Smi::ZoneHandle()).Value() -> assertion failure This kind of behavior is completely unexpected in most parts of the system. TBR=iposva@google.com,asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=39455

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/code_generator_test.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Google)
TBR to make the bot green However we might want to fix the handle system.
6 years, 4 months ago (2014-08-21 16:06:15 UTC) #1
Vyacheslav Egorov (Google)
Committed patchset #1 manually as 39455 (presubmit successful).
6 years, 4 months ago (2014-08-21 16:07:19 UTC) #2
Ivan Posva
6 years, 4 months ago (2014-08-21 16:33:12 UTC) #3
Message was sent while issue was closed.
LGTM with comment addressed.

-Ivan

https://codereview.chromium.org/473913005/diff/1/runtime/vm/code_generator_te...
File runtime/vm/code_generator_test.cc (right):

https://codereview.chromium.org/473913005/diff/1/runtime/vm/code_generator_te...
runtime/vm/code_generator_test.cc:512: arguments->Add(new LiteralNode(kPos,
Instance::ZoneHandle()));
Object::null_object() would be the correct thing to use here.

Powered by Google App Engine
This is Rietveld 408576698