Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 473763002: Fix Dartium build: (Closed)

Created:
6 years, 4 months ago by Ivan Posva
Modified:
6 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix Windows Dartium build: - Cannot access dart::bin::* from Dartium build. Committed: https://code.google.com/p/dart/source/detail?r=39238

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -6 lines) Patch
M runtime/bin/gen_snapshot.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/bin/main.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/bin/thread.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/thread_android.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/thread_linux.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/thread_macos.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/thread_win.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/os_win.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ivan Posva
TBR
6 years, 4 months ago (2014-08-14 04:59:50 UTC) #1
Ivan Posva
6 years, 4 months ago (2014-08-14 05:00:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r39238 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698