Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 473663002: Fix bug that prevent the entry point from being added to the pubspec (Closed)

Created:
6 years, 4 months ago by dgrove
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix bug that prevent the entry point from being added to the pubspec when there was no transformers section. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=39227

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M pkg/polymer/bin/new_entry.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dgrove
6 years, 4 months ago (2014-08-13 21:41:08 UTC) #1
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/473663002/diff/1/pkg/polymer/bin/new_entry.dart File pkg/polymer/bin/new_entry.dart (right): https://codereview.chromium.org/473663002/diff/1/pkg/polymer/bin/new_entry.dart#newcode136 pkg/polymer/bin/new_entry.dart:136: entryPoints.add(entryPoint); alternatively, you could remove the initialization and ...
6 years, 4 months ago (2014-08-13 21:56:31 UTC) #2
dgrove
6 years, 4 months ago (2014-08-13 22:35:25 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r39227 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698