Issue 47293002: Add Dart_LibraryId method unblocking landing 45613003. TBR

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 47293002: Add Dart_LibraryId method unblocking landing 45613003. TBR (Closed)

Created:
7 years, 1 month ago by Jacob

Modified:
7 years, 1 month ago

Reviewers:
hausner, sra1, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add Dart_LibraryId method unblocking landing 45613003. TBR BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=29318

Patch Set 1 : Ready to review #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -0 lines)			Patch
M	runtime/include/dart_mirrors_api.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	2 chunks	+37 lines, -0 lines	0 comments	Download
M	runtime/vm/mirrors_api_impl.cc	View	1 chunk	+13 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jacob

The existing implementation of this functionality in DartUtilities.cpp in the Dartium code base crashes debug ...

7 years, 1 month ago (2013-10-26 22:36:30 UTC) #1

Jacob

Committed patchset #1 manually as r29318 (presubmit successful).

7 years, 1 month ago (2013-10-26 22:55:50 UTC) #3

siva

7 years, 1 month ago (2013-10-28 02:27:48 UTC) #4

Message was sent while issue was closed.

It probably makes sense to move this API function to
include/dart_debugger_api.h

and the implementation to
runtime/vm/debugger_api_impl.cc

all the other LibraryId functions seem to be there.

https://codereview.chromium.org/47293002/diff/50001/runtime/vm/mirrors_api_im...
File runtime/vm/mirrors_api_impl.cc (right):

https://codereview.chromium.org/47293002/diff/50001/runtime/vm/mirrors_api_im...
runtime/vm/mirrors_api_impl.cc:333: }
Usually we report an error when NULL pointers are passed in, in this case it
would be

  if (library_id == NULL) {
    RETURN_NULL_ERROR(library_id);
  }

https://codereview.chromium.org/47293002/diff/50001/runtime/vm/mirrors_api_im...
runtime/vm/mirrors_api_impl.cc:336: }
Once the NULL check is in place you could remove this != NULL check.

Expand Messages | Collapse Messages