Issue 472883002: Test scripts: Detect and report error in accessing window.parent in browser_controller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 472883002: Test scripts: Detect and report error in accessing window.parent in browser_controller. (Closed)

Created:
6 years, 4 months ago by Bill Hesse

Modified:
6 years, 4 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Test scripts: Detect and report error in accessing window.parent in browser_controller. BUG= R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=39249

Patch Set 1 : #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -3 lines)			Patch
	M	tools/testing/dart/test_controller.js	View		1 chunk	+26 lines, -3 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ricow1

lgtm for debugging purposes https://codereview.chromium.org/472883002/diff/2/tools/testing/dart/test_controller.js File tools/testing/dart/test_controller.js (right): https://codereview.chromium.org/472883002/diff/2/tools/testing/dart/test_controller.js#newcode135 tools/testing/dart/test_controller.js:135: if (!reportingDriverWindowError) { I assume ...

6 years, 4 months ago (2014-08-14 15:24:10 UTC) #2

Bill Hesse

6 years, 4 months ago (2014-08-14 15:31:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 39249 (presubmit successful).

Expand Messages | Collapse Messages