Issue 472613002: Update analysis server and integration tests to match new ChangeContentOverlay.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 472613002: Update analysis server and integration tests to match new ChangeContentOverlay. (Closed)

Created:
6 years, 4 months ago by Paul Berry

Modified:
6 years, 4 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update analysis server and integration tests to match new ChangeContentOverlay. The spec was changed in r39199 so that ChangeContentOverlay contains a list of edits rather than a single edit. This updates the analysis server and integration tests accordingly. BUG=dartbug.com/20495 R=brianwilkerson@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39218

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+160 lines, -86 lines)			Patch
M	pkg/analysis_server/lib/src/analysis_server.dart	View	2 chunks	+18 lines, -12 lines	0 comments	Download
M	pkg/analysis_server/lib/src/domain_analysis.dart	View	3 chunks	+18 lines, -13 lines	0 comments	Download
M	pkg/analysis_server/test/domain_analysis_test.dart	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/test/integration/analysis/test_all.dart	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A	pkg/analysis_server/test/integration/analysis/update_content_list_test.dart	View	1 chunk	+62 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/integration/analysis/update_content_test.dart	View	2 chunks	+10 lines, -6 lines	0 comments	Download
M	pkg/analysis_services/lib/correction/change.dart	View	6 chunks	+35 lines, -12 lines	0 comments	Download
M	pkg/analysis_services/test/correction/assist_test.dart	View	3 chunks	+3 lines, -12 lines	0 comments	Download
M	pkg/analysis_services/test/correction/fix_test.dart	View	2 chunks	+3 lines, -11 lines	0 comments	Download
M	pkg/analysis_services/test/refactoring/abstract_rename.dart	View	4 chunks	+4 lines, -14 lines	0 comments	Download
M	pkg/pkg.status	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

6 years, 4 months ago (2014-08-13 20:05:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r39218 (presubmit successful).

Expand Messages | Collapse Messages