Issue 472373002: Support potential edits

Issue 472373002: Support potential edits (Closed)

Created:
6 years, 4 months ago by Brian Wilkerson

Modified:
6 years, 4 months ago

Reviewers:
Paul Berry, scheglov

CC:
reviews_dartlang.org, jwren

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support potential edits R=paulberry@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39309

Patch Set 1 #

Total comments: 2

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+105 lines, -7 lines)			Patch
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SourceEdit.java	View	3 chunks	+31 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/doc/api.html	View	3 chunks	+28 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/integration/integration_test_methods.dart	View	1 chunk	+11 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/integration/protocol_matchers.dart	View	4 chunks	+6 lines, -1 line	0 comments	Download
M	pkg/analysis_server/tool/spec/spec_input.html	View	2 chunks	+29 lines, -1 line	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scheglov

LGTM https://codereview.chromium.org/472373002/diff/1/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (right): https://codereview.chromium.org/472373002/diff/1/pkg/analysis_server/tool/spec/spec_input.html#newcode1247 pkg/analysis_server/tool/spec/spec_input.html:1247: <field name="potentialChanges" optional="true"> "potentialEdits"?

6 years, 4 months ago (2014-08-15 18:38:35 UTC) #2

Brian Wilkerson

https://codereview.chromium.org/472373002/diff/1/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (right): https://codereview.chromium.org/472373002/diff/1/pkg/analysis_server/tool/spec/spec_input.html#newcode1247 pkg/analysis_server/tool/spec/spec_input.html:1247: <field name="potentialChanges" optional="true"> > "potentialEdits"? I chose the name ...

6 years, 4 months ago (2014-08-15 18:44:24 UTC) #3

Brian Wilkerson

6 years, 4 months ago (2014-08-15 18:51:22 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as 39309 (presubmit successful).

Expand Messages | Collapse Messages