Issue 47233002: - Revert parts of r29315 while attempting to reproduce

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 47233002: - Revert parts of r29315 while attempting to reproduce (Closed)

Created:
7 years, 1 month ago by Ivan Posva

Modified:
7 years, 1 month ago

Reviewers:
Cutch, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

- Revert parts of r29315 while attempting to reproduce unexplained buildbot failures locally. Committed: https://code.google.com/p/dart/source/detail?r=29317

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -27 lines)			Patch
M	runtime/lib/isolate.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/lib/isolate_patch.dart	View	4 chunks	+9 lines, -17 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Ivan Posva

TBR It is still unclear to me how a change to VM internal isolate handling ...

7 years, 1 month ago (2013-10-26 21:50:24 UTC) #1

Ivan Posva

7 years, 1 month ago (2013-10-26 21:50:45 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r29317 (presubmit successful).