Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Issue 472303002: Revert "Switch to a fix-point based range analysis to improve its precision." (Closed)

Created:
6 years, 4 months ago by Vyacheslav Egorov (Google)
Modified:
6 years, 4 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Revert "Switch to a fix-point based range analysis to improve its precision." This reverts r39293. The dart2js part of the tree is on fire. TBR=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=39296

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+655 lines, -874 lines) Patch
M runtime/vm/flow_graph_range_analysis.h View 9 chunks +49 lines, -116 lines 0 comments Download
M runtime/vm/flow_graph_range_analysis.cc View 22 chunks +505 lines, -610 lines 0 comments Download
M runtime/vm/flow_graph_range_analysis_test.cc View 2 chunks +89 lines, -135 lines 0 comments Download
M runtime/vm/intermediate_language.h View 12 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Google)
6 years, 4 months ago (2014-08-15 15:44:18 UTC) #1
Florian Schneider
lgtm
6 years, 4 months ago (2014-08-15 15:44:34 UTC) #2
Vyacheslav Egorov (Google)
6 years, 4 months ago (2014-08-15 15:44:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 39296 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698