Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 47213007: Fix file-system-entity watching on Windows. (Closed)

Created:
7 years, 1 month ago by Anders Johnsen
Modified:
7 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix file-system-entity watching on Windows. This includes disabling a test, as Windows have no way of detecting when the watched directory is deleted. BUG= Committed: https://code.google.com/p/dart/source/detail?r=29379

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M runtime/bin/file_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/file_system_watcher_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
TBR
7 years, 1 month ago (2013-10-28 17:57:04 UTC) #1
Anders Johnsen
Committed patchset #1 manually as r29379 (presubmit successful).
7 years, 1 month ago (2013-10-28 17:57:55 UTC) #2
Søren Gjesse
7 years, 1 month ago (2013-10-29 07:20:54 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698