Issue 471843003: Revert revision 39101 "Avoid linear search for function lookup."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 471843003: Revert revision 39101 "Avoid linear search for function lookup." (Closed)

Created:
6 years, 4 months ago by ricow1

Modified:
6 years, 4 months ago

Reviewers:
koda, kasperl

CC:
reviews_dartlang.org, vm-dev_dartlang.org, vsm

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Revert revision 39101 "Avoid linear search for function lookup." This is causing breakage of the pop pop win sample. For details see issue 20517 This revert had a minor merge conflict for a todo comment R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=39246

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -78 lines)			Patch
M	runtime/vm/object.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/object.cc	View	3 chunks	+10 lines, -73 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/standalone/issue14236_test.dart	View	Binary file		0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

6 years, 4 months ago (2014-08-14 12:39:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r39246 (presubmit successful).

Expand Messages | Collapse Messages