Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 471743002: - Make sure that the threads for dart::bin are in the correct namespace. (Closed)

Created:
6 years, 4 months ago by Ivan Posva
Modified:
6 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Make sure that the threads for dart::bin are in the correct namespace. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=39233

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -56 lines) Patch
M runtime/bin/dbg_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/dbg_connection.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/dbg_connection_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/dbg_connection_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/dbg_connection_macos.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/dbg_connection_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/dbg_message.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/dbg_message.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/eventhandler_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/eventhandler_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/eventhandler_macos.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/eventhandler_win.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/eventhandler_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/lockers.h View 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/bin/process.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/process.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/process_android.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M runtime/bin/process_linux.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M runtime/bin/process_macos.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M runtime/bin/process_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/secure_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/secure_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/thread.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/bin/thread_android.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/bin/thread_android.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/bin/thread_linux.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/bin/thread_linux.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/bin/thread_macos.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/bin/thread_macos.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/bin/thread_win.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/bin/thread_win.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/bin/vmservice_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/lockers.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
6 years, 4 months ago (2014-08-13 23:17:39 UTC) #1
siva
lgtm
6 years, 4 months ago (2014-08-13 23:26:48 UTC) #2
Ivan Posva
6 years, 4 months ago (2014-08-14 00:06:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r39233 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698