Issue 471143002: first incomplete cut at invocation/accessor suggestions

Issue 471143002: first incomplete cut at invocation/accessor suggestions (Closed)

Created:
6 years, 4 months ago by danrubel

Modified:
6 years, 4 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

first incomplete cut at invocation/accessor suggestions BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39281

Patch Set 3 : remove unused imports #

Total comments: 4

Patch Set 4 : merge #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+254 lines, -4 lines)			Patch
M	pkg/analysis_server/test/domain_completion_test.dart	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	pkg/analysis_services/lib/src/completion/dart_completion_manager.dart	View		2 chunks	+6 lines, -2 lines	0 comments	Download
A	pkg/analysis_services/lib/src/completion/invocation_computer.dart	View	1 2 3	1 chunk	+160 lines, -0 lines	0 comments	Download
M	pkg/analysis_services/test/completion/completion_test_util.dart	View		5 chunks	+22 lines, -2 lines	0 comments	Download
A	pkg/analysis_services/test/completion/invocation_computer_test.dart	View	1 2	1 chunk	+55 lines, -0 lines	0 comments	Download
M	pkg/analysis_services/test/completion/test_all.dart	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scheglov

LGTM https://codereview.chromium.org/471143002/diff/40001/pkg/analysis_services/lib/src/completion/invocation_computer.dart File pkg/analysis_services/lib/src/completion/invocation_computer.dart (right): https://codereview.chromium.org/471143002/diff/40001/pkg/analysis_services/lib/src/completion/invocation_computer.dart#newcode125 pkg/analysis_services/lib/src/completion/invocation_computer.dart:125: if (!element.isSynthetic) { Out of curiosity, can methods ...

6 years, 4 months ago (2014-08-14 20:20:27 UTC) #2

Brian Wilkerson

https://codereview.chromium.org/471143002/diff/40001/pkg/analysis_services/lib/src/completion/invocation_computer.dart File pkg/analysis_services/lib/src/completion/invocation_computer.dart (right): https://codereview.chromium.org/471143002/diff/40001/pkg/analysis_services/lib/src/completion/invocation_computer.dart#newcode125 pkg/analysis_services/lib/src/completion/invocation_computer.dart:125: if (!element.isSynthetic) { > Out of curiosity, can methods ...

6 years, 4 months ago (2014-08-14 20:27:20 UTC) #3

danrubel

https://codereview.chromium.org/471143002/diff/40001/pkg/analysis_services/lib/src/completion/invocation_computer.dart File pkg/analysis_services/lib/src/completion/invocation_computer.dart (right): https://codereview.chromium.org/471143002/diff/40001/pkg/analysis_services/lib/src/completion/invocation_computer.dart#newcode135 pkg/analysis_services/lib/src/completion/invocation_computer.dart:135: String name = element.name; On 2014/08/14 20:20:27, scheglov wrote: ...

6 years, 4 months ago (2014-08-15 02:24:45 UTC) #4

danrubel

6 years, 4 months ago (2014-08-15 02:29:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as 39281 (presubmit successful).

Expand Messages | Collapse Messages