Issue 47073009: Improve indexOf for one byte string receiver to work with other string classes.

Issue 47073009: Improve indexOf for one byte string receiver to work with other string classes. (Closed)

Created:
7 years, 1 month ago by srdjan

Modified:
7 years, 1 month ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Improve indexOf for one byte string receiver to work with other string classes. Optimize access to core class’s class-ids. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=29610

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Total comments: 2

Patch Set 9 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -12 lines)			Patch
M	runtime/lib/string.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/lib/string_patch.dart	View	1 2 3 4 5 6 7 8	6 chunks	+23 lines, -12 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 2 3 4 5 6	2 chunks	+30 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/symbols.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

lgtm https://codereview.chromium.org/47073009/diff/370001/runtime/lib/string_patch.dart File runtime/lib/string_patch.dart (right): https://codereview.chromium.org/47073009/diff/370001/runtime/lib/string_patch.dart#newcode585 runtime/lib/string_patch.dart:585: if ((pattern.length == 1) && (start == 0) ...

7 years, 1 month ago (2013-10-30 23:35:02 UTC) #2

srdjan

https://codereview.chromium.org/47073009/diff/370001/runtime/lib/string_patch.dart File runtime/lib/string_patch.dart (right): https://codereview.chromium.org/47073009/diff/370001/runtime/lib/string_patch.dart#newcode585 runtime/lib/string_patch.dart:585: if ((pattern.length == 1) && (start == 0) && ...

7 years, 1 month ago (2013-10-30 23:38:40 UTC) #3

srdjan

7 years, 1 month ago (2013-10-30 23:51:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #9 manually as r29610 (presubmit successful).

Expand Messages | Collapse Messages