Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 470353003: Detect compile errors when setting breakpoint (Closed)

Created:
6 years, 4 months ago by hausner
Modified:
6 years, 4 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Detect compile errors when setting breakpoint When the VM is started with the —-debug option, it compiles the main function eagerly to set a one-shot breakpoint. So far we silently dropped errors during the compilation, which is wrong. This change propagates the error to the caller. Fixes issue https://code.google.com/p/dart/issues/detail?id=20558 R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=39390

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M runtime/vm/debugger.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/debugger.cc View 3 chunks +14 lines, -12 lines 0 comments Download
M runtime/vm/debugger_api_impl.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
6 years, 4 months ago (2014-08-19 19:51:29 UTC) #1
regis
LGTM
6 years, 4 months ago (2014-08-19 20:26:12 UTC) #2
hausner
6 years, 4 months ago (2014-08-19 22:34:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r39390 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698