Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 469673002: Add union types to the analysis server API spec. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Add union types to the analysis server API spec. R=brianwilkerson@google.com, jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=39208

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -28 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/doc/api.html View 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 1 chunk +44 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/api.dart View 3 chunks +17 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_inttest_methods.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_matchers.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/from_html.dart View 4 chunks +25 lines, -8 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +8 lines, -7 lines 0 comments Download
M pkg/analysis_server/tool/spec/to_html.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paul Berry
Inspired by the fact that the integration tests failed to detect the protocol changes introduced ...
6 years, 4 months ago (2014-08-13 03:57:59 UTC) #1
Brian Wilkerson
LGTM
6 years, 4 months ago (2014-08-13 13:44:36 UTC) #2
jwren
LGTM
6 years, 4 months ago (2014-08-13 14:29:18 UTC) #3
Paul Berry
6 years, 4 months ago (2014-08-13 17:38:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r39208 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698