Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 469543002: Add a test to verify that analysis server code generation is up to date. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a test to verify that analysis server code generation is up to date. This test will run on the Windows, Linux, and MacOS buildbots, so it should help ensure that code generation works properly on all of those platforms. R=jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=39201

Patch Set 1 #

Patch Set 2 : Remove unused imports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -43 lines) Patch
A pkg/analysis_server/tool/spec/check_all_test.dart View 1 chunk +42 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_analysis_server.dart View 1 3 chunks +25 lines, -12 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_inttest_methods.dart View 1 3 chunks +10 lines, -8 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java.dart View 1 2 chunks +8 lines, -7 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_matchers.dart View 1 2 chunks +7 lines, -5 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_tools.dart View 2 chunks +58 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generate_all.dart View 1 chunk +38 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/generate_files View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/analysis_server/tool/spec/to_html.dart View 1 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 4 months ago (2014-08-12 22:59:30 UTC) #1
jwren
On 2014/08/12 22:59:30, Paul Berry wrote: LGTM
6 years, 4 months ago (2014-08-13 14:41:44 UTC) #2
Paul Berry
6 years, 4 months ago (2014-08-13 15:29:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r39201 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698