Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 469423004: Fix clang compilation error in jscre. (Closed)

Created:
6 years, 4 months ago by rmacnak
Modified:
6 years, 4 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix clang compilation error in jscre. ../../dart/runtime/third_party/jscre/pcre_internal.h:412:5: error: implicit conversion of NULL constant to 'int' [-Werror,-Wnull-conversion] ASSERT(isBracketStartOpcode(*opcodePtr) || *opcodePtr == OP_ALT); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../dart/runtime/third_party/jscre/pcre_internal.h:86:72: note: expanded from macro 'ASSERT' #define ASSERT(x) if (!(x)) *(reinterpret_cast<volatile int*>(NULL)) = NULL BUG=http://dartbug.com/19324 R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=39276

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/third_party/jscre/pcre_internal.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmacnak
6 years, 4 months ago (2014-08-14 22:56:56 UTC) #1
Ivan Posva
LGTM -ip
6 years, 4 months ago (2014-08-14 22:58:54 UTC) #2
rmacnak
6 years, 4 months ago (2014-08-14 23:19:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 39276.

Powered by Google App Engine
This is Rietveld 408576698