Fixed expect, protect methods to allow any set of arguments

Fixed expect, protect methods to allow any set of arguments

removed dependency on meta, fixed dart2js warning about double type check

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29487

[kevmoo-old, 2013-10-29 18:51:04]

Eliminated a lot of siggi's TODOs

Made methods able to handle arbitrary arguments, including positional arguments

[Siggi Cherem (dart-lang), 2013-10-29 20:12:16]

nice! Thanks Kevin!

Some suggestions below, but otherwise lgtm

https://codereview.chromium.org/46883011/diff/1/pkg/unittest/lib/unittest.dart
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/46883011/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:458: if(invocation.memberName != #call) return
super.noSuchMethod(invocation);
nit: missing space ("if (")

https://codereview.chromium.org/46883011/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:463: return Function.apply(callback,
invocation.positionalArguments, invocation.namedArguments);
nit: 80 column.

https://codereview.chromium.org/46883011/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:473: Function get asFunction {
How about add 'implements Function' on the top instead?

If not, consider changing this function as:

Function get asFunction => (this as dynamic);

[kevmoo-old, 2013-10-29 20:40:24]

https://codereview.chromium.org/46883011/diff/1/pkg/unittest/lib/unittest.dart
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/46883011/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:458: if(invocation.memberName != #call) return
super.noSuchMethod(invocation);
On 2013/10/29 20:12:16, Siggi Cherem (dart-lang) wrote:
> nit: missing space ("if (")

Done.

https://codereview.chromium.org/46883011/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:463: return Function.apply(callback,
invocation.positionalArguments, invocation.namedArguments);
On 2013/10/29 20:12:16, Siggi Cherem (dart-lang) wrote:
> nit: 80 column.

Done.

https://codereview.chromium.org/46883011/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:473: Function get asFunction {
On 2013/10/29 20:12:16, Siggi Cherem (dart-lang) wrote:
> How about add 'implements Function' on the top instead?
> 
> If not, consider changing this function as:
> 
> Function get asFunction => (this as dynamic);

Then we get warnings about not implementing 'call' which means we should add the
proxy attribute.

Added a todo for once the annotations settle down...but not critical.

[kevmoo-old, 2013-10-29 20:43:29]

Committed patchset #2 manually as r29487 (presubmit successful).

[Siggi Cherem (dart-lang), 2013-10-29 20:54:27]

On 2013/10/29 20:40:24, kevmoo wrote:
> https://codereview.chromium.org/46883011/diff/1/pkg/unittest/lib/unittest.dart
> File pkg/unittest/lib/unittest.dart (right):
> 
>
https://codereview.chromium.org/46883011/diff/1/pkg/unittest/lib/unittest.dar...
> pkg/unittest/lib/unittest.dart:458: if(invocation.memberName != #call) return
> super.noSuchMethod(invocation);
> On 2013/10/29 20:12:16, Siggi Cherem (dart-lang) wrote:
> > nit: missing space ("if (")
> 
> Done.
> 
>
https://codereview.chromium.org/46883011/diff/1/pkg/unittest/lib/unittest.dar...
> pkg/unittest/lib/unittest.dart:463: return Function.apply(callback,
> invocation.positionalArguments, invocation.namedArguments);
> On 2013/10/29 20:12:16, Siggi Cherem (dart-lang) wrote:
> > nit: 80 column.
> 
> Done.
> 
>
https://codereview.chromium.org/46883011/diff/1/pkg/unittest/lib/unittest.dar...
> pkg/unittest/lib/unittest.dart:473: Function get asFunction {
> On 2013/10/29 20:12:16, Siggi Cherem (dart-lang) wrote:
> > How about add 'implements Function' on the top instead?
> > 
> > If not, consider changing this function as:
> > 
> > Function get asFunction => (this as dynamic);
> 
> Then we get warnings about not implementing 'call' which means we should add
the
> proxy attribute.

weird - we get that warning even though 'call' is not declared in Function? I
thought the editor no longer presented warnings if you say 'implements X' and
explicitly have a 'noSuchMethod' on the same declaration.

> 
> Added a todo for once the annotations settle down...but not critical.