Issue 46873004: Revert "Do not directly load smi constants larger than a 16 bit payload on ia32."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 46873004: Revert "Do not directly load smi constants larger than a 16 bit payload on ia32." (Closed)

Created:
7 years, 1 month ago by Bill Hesse

Modified:
7 years, 1 month ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "Do not directly load smi constants larger than a 16 bit payload on ia32." There is an assertion failure on debug VM tests. BUG= R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=29458

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -79 lines)			Patch
M	runtime/vm/assembler_arm.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/assembler_ia32.h	View	4 chunks	+1 line, -18 lines	0 comments	Download
M	runtime/vm/assembler_ia32.cc	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	runtime/vm/assembler_mips.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/assembler_x64.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	5 chunks	+31 lines, -27 lines	0 comments	Download
M	runtime/vm/locations.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Bill Hesse

7 years, 1 month ago (2013-10-29 16:49:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r29458 (presubmit successful).