Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 468233003: Write an integration test for analysis.navigation notification. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Write an integration test for analysis.navigation notification. Also, add the missing ElementKind "PARAMETER", and sort the ElementKinds. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=39267

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -12 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ElementKind.java View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/analysis_server/doc/api.html View 1 chunk +1 line, -1 line 0 comments Download
A pkg/analysis_server/test/integration/analysis/navigation_test.dart View 1 chunk +102 lines, -0 lines 4 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Paul Berry
6 years, 4 months ago (2014-08-14 20:38:41 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/468233003/diff/1/pkg/analysis_server/test/integration/analysis/navigation_test.dart File pkg/analysis_server/test/integration/analysis/navigation_test.dart (right): https://codereview.chromium.org/468233003/diff/1/pkg/analysis_server/test/integration/analysis/navigation_test.dart#newcode82 pkg/analysis_server/test/integration/analysis/navigation_test.dart:82: // - COMPILATION_UNIT I would expect compilation units ...
6 years, 4 months ago (2014-08-14 20:53:44 UTC) #2
Paul Berry
https://codereview.chromium.org/468233003/diff/1/pkg/analysis_server/test/integration/analysis/navigation_test.dart File pkg/analysis_server/test/integration/analysis/navigation_test.dart (right): https://codereview.chromium.org/468233003/diff/1/pkg/analysis_server/test/integration/analysis/navigation_test.dart#newcode82 pkg/analysis_server/test/integration/analysis/navigation_test.dart:82: // - COMPILATION_UNIT On 2014/08/14 20:53:44, Brian Wilkerson wrote: ...
6 years, 4 months ago (2014-08-14 20:58:05 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/468233003/diff/1/pkg/analysis_server/test/integration/analysis/navigation_test.dart File pkg/analysis_server/test/integration/analysis/navigation_test.dart (right): https://codereview.chromium.org/468233003/diff/1/pkg/analysis_server/test/integration/analysis/navigation_test.dart#newcode82 pkg/analysis_server/test/integration/analysis/navigation_test.dart:82: // - COMPILATION_UNIT > That was my guess too, ...
6 years, 4 months ago (2014-08-14 20:59:02 UTC) #4
Paul Berry
https://codereview.chromium.org/468233003/diff/1/pkg/analysis_server/test/integration/analysis/navigation_test.dart File pkg/analysis_server/test/integration/analysis/navigation_test.dart (right): https://codereview.chromium.org/468233003/diff/1/pkg/analysis_server/test/integration/analysis/navigation_test.dart#newcode82 pkg/analysis_server/test/integration/analysis/navigation_test.dart:82: // - COMPILATION_UNIT On 2014/08/14 20:59:02, Brian Wilkerson wrote: ...
6 years, 4 months ago (2014-08-14 21:06:14 UTC) #5
Paul Berry
6 years, 4 months ago (2014-08-14 21:06:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r39267 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698